-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random tls impersonate #489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Enhancement
Most issues will probably ask for additions or changes.
label
Jun 22, 2023
DialContext: dialer.Dial, | ||
DialTLSContext: func(ctx context.Context, network, addr string) (net.Conn, error) { | ||
if options.TlsImpersonate { | ||
return dialer.DialTLSWithConfigImpersonate(ctx, network, addr, &tls.Config{InsecureSkipVerify: true, MinVersion: tls.VersionTLS10}, impersonate.Random, nil) |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check
InsecureSkipVerify should not be used in production code.
DialContext: dialer.Dial, | ||
DialTLSContext: func(ctx context.Context, network, addr string) (net.Conn, error) { | ||
if options.TlsImpersonate { | ||
return dialer.DialTLSWithConfigImpersonate(ctx, network, addr, &tls.Config{InsecureSkipVerify: true, MinVersion: tls.VersionTLS10}, impersonate.Random, nil) |
Check failure
Code scanning / CodeQL
Insecure TLS configuration
Using insecure TLS version VersionTLS10 for MinVersion.
ehsandeep
added
the
Status: In Progress
This issue is being worked on, and has someone assigned.
label
Jun 27, 2023
Mzack9999
removed
the
Status: In Progress
This issue is being worked on, and has someone assigned.
label
Jul 3, 2023
dogancanbakir
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehsandeep
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements random TLS impersonate for standard http crawler. Hybrid crawling already support natively tls extension randomization.
Closes #136