Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix -match-regex err #565

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix -match-regex err #565

merged 2 commits into from
Aug 21, 2023

Conversation

dogancanbakir
Copy link
Member

Closes #563.

Before:

$ go run main.go -u https://google.com -match-regex "^https://google.com$"

   __        __                
  / /_____ _/ /____ ____  ___ _
 /  '_/ _  / __/ _  / _ \/ _  /
/_/\_\\_,_/\__/\_,_/_//_/\_,_/                                                   

                projectdiscovery.io

[INF] Current katana version v1.0.3 (latest)
[INF] Started standard crawling for => https://google.com
https://google.com
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
[ERR] Could not evaluate DSL expression: Unexpected end of expression
^C[INF] - Ctrl+C pressed in Terminal

After:

$ go run main.go -u https://google.com -match-regex "^https://google.com$"

   __        __                
  / /_____ _/ /____ ____  ___ _
 /  '_/ _  / __/ _  / _ \/ _  /
/_/\_\\_,_/\__/\_,_/_//_/\_,_/                                                   

                projectdiscovery.io

[INF] Current katana version v1.0.3 (latest)
[INF] Started standard crawling for => https://google.com
https://google.com
^C[INF] - Ctrl+C pressed in Terminal

@dogancanbakir dogancanbakir self-assigned this Aug 19, 2023
@Mzack9999 Mzack9999 linked an issue Aug 21, 2023 that may be closed by this pull request
DSL match expression errors when specifying match-regex #563
Closed
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Aug 21, 2023
Mzack9999
Mzack9999 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

$ go run main.go -u https://google.com -match-regex "^https://google.com$"
...
https://google.com
^C[INF] - Ctrl+C pressed in Terminal

@ehsandeep ehsandeep merged commit ca3fa00 into dev Aug 21, 2023
13 checks passed
@ehsandeep ehsandeep deleted the fix_match_regex_err branch August 21, 2023 08:13
@chenrui333 chenrui333 mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@ehsandeep ehsandeep

@dogancanbakir dogancanbakir

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSL match expression errors when specifying match-regex
3 participants
@dogancanbakir @ehsandeep @Mzack9999