Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding interact keepalive to reduce server-side id pruning #3680

Merged
merged 7 commits into from
May 20, 2023

Conversation

Mzack9999
Copy link
Member

Proposed changes

This PR adds support for interactsh keep-alive, similarly to tcp/http concept. The session is kept-alive with an hardcoded interval one 1 minute on the same server where the first session was created. This should reduce the amount of missing correlation id errors, while increasing the OOB detection, that would otherwise be rejected by the server.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 13, 2023
@Mzack9999 Mzack9999 self-assigned this May 13, 2023
@ehsandeep ehsandeep linked an issue May 16, 2023 that may be closed by this pull request
@ehsandeep ehsandeep marked this pull request as ready for review May 19, 2023 16:20
@ehsandeep ehsandeep merged commit dfd4d5b into dev May 20, 2023
@ehsandeep ehsandeep deleted the bugfix-interact-random-eviction branch May 20, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The correlation id was not found (probably evicted due to inactivity
2 participants