Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #4008

Merged
merged 44 commits into from
Aug 1, 2023
Merged

Spelling #4008

merged 44 commits into from
Aug 1, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jul 30, 2023

Proposed changes

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/nuclei/actions/runs/5705171531#summary-15459544539

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/nuclei/actions/runs/5705175675#summary-15459553779

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

jsoref added 30 commits July 30, 2023 02:59
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref added 14 commits July 30, 2023 03:04
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@ehsandeep ehsandeep requested a review from tarunKoyalwar July 31, 2023 10:25
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoref, thank you for making all the changes and maintaining this project; looks like we also can add this workflow in the nuclei project to avoid these mistakes in the future as well.

do you think you can also add this workflow in this PR?

@jsoref
Copy link
Contributor Author

jsoref commented Aug 1, 2023

I tend to prefer to do the workflow in a followup PR (I think mostly because I'm afraid of drift between when the PR is originally authored, reviewed, and merged), but if you'd like to do it here, I can.

@ehsandeep
Copy link
Member

@jsoref makes sense, let's do it in the follow-up PR.

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

doesn't seem like there are any breaking changes to SDK , unless they are using

// GitHub token used to clone/pull from private repos for custom templates
GithubToken string
// GithubTemplateRepo is the list of custom public/private templates GitHub repos
GithubTemplateRepo []string
// GitHubTemplateDisableDownload disables downloading templates from custom GitHub repositories

directly from SDK (less likely )

@ehsandeep ehsandeep merged commit 4c1c530 into projectdiscovery:dev Aug 1, 2023
@jsoref jsoref deleted the spelling branch August 1, 2023 18:35
@jsoref jsoref mentioned this pull request Aug 1, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants