Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added asreproastable #4990

Merged
merged 3 commits into from
Apr 7, 2024
Merged

feat: added asreproastable #4990

merged 3 commits into from
Apr 7, 2024

Conversation

daffainfo
Copy link
Contributor

Proposed changes

Added asreproasting method in Ldap.client module, #4989

This is my first pull req to nuclei repo, let me know if there's something wrong about my pull request

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tarunKoyalwar tarunKoyalwar self-requested a review April 4, 2024 12:21
@tarunKoyalwar tarunKoyalwar linked an issue Apr 4, 2024 that may be closed by this pull request
JS module to do ASREProasting #4989
Closed
@GeorginaReeder
Copy link

Thanks so much for this @daffainfo , and congrats on your first pull request! :)

tarunKoyalwar
tarunKoyalwar approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daffainfo , thanks for PR , feel free to directly open PRs related to js modules

Note:

  • As far as i know , AsReproasting can also be done on disabled accounts so i have removed the FilterAccountEnabled Filter

cc: @pussycat0x for visibility

@tarunKoyalwar tarunKoyalwar requested a review from ehsandeep April 4, 2024 15:39
@ehsandeep ehsandeep merged commit ffbe5de into projectdiscovery:dev Apr 7, 2024
12 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS module to do ASREProasting
4 participants
@daffainfo @GeorginaReeder @tarunKoyalwar @ehsandeep