Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tempalte-id validation #5261

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Fix tempalte-id validation #5261

merged 3 commits into from
Jun 15, 2024

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Jun 4, 2024 •
edited
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RamanaReddy0M RamanaReddy0M self-assigned this Jun 4, 2024
@RamanaReddy0M RamanaReddy0M linked an issue Jun 4, 2024 that may be closed by this pull request
Nuclei -validate not flagging invalid ID in template #5247
Closed
@RamanaReddy0M RamanaReddy0M force-pushed the issue-5247-id-validate branch from cf64492 to 49ad3c4 Compare June 4, 2024 20:44
dogancanbakir
dogancanbakir approved these changes Jun 5, 2024
View reviewed changes
pkg/templates/templates.go Show resolved Hide resolved
@dogancanbakir dogancanbakir requested a review from ehsandeep June 5, 2024 08:05
@ehsandeep ehsandeep merged commit 0eddafe into dev Jun 15, 2024
12 checks passed
@ehsandeep ehsandeep deleted the issue-5247-id-validate branch June 15, 2024 22:57
@BrewTestBot BrewTestBot mentioned this pull request Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nuclei -validate not flagging invalid ID in template
3 participants
@RamanaReddy0M @ehsandeep @dogancanbakir