Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing close statements file.Close() & ticker.Stop() #5436

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ShuBo6
Copy link
Contributor

@ShuBo6 ShuBo6 commented Jul 23, 2024

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep requested a review from tarunKoyalwar July 23, 2024 07:36
@GeorginaReeder
Copy link

Thanks for your contribution @ShuBo6 !

@ShuBo6
Copy link
Contributor Author

ShuBo6 commented Jul 24, 2024

image There are errors in the testing process, but they don't seem to be related to the impact of the changes I'm making in this commit. Do I need to make any changes?

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! thanks for contributing @ShuBo6

about the test github actions are sometimes flaky, works fine locally

CI=true go test -v ./...                                                           
ok  	github.com/projectdiscovery/nuclei/v3/lib	0.973s
=== RUN   TestSimpleNuclei
[INF] Templates clustered: 14 (Reduced 10 Requests)
[nameserver-fingerprint] scanme.sh
[caa-fingerprint] scanme.sh
{"duration":"0:00:01","errors":"1","hosts":"1","matched":"2","percent":"94","requests":"16","rps":"26","startedAt":"2024-07-24T16:46:53.328694+05:30","templates":"24","total":"17"}
--- PASS: TestSimpleNuclei (4.01s)
=== RUN   TestSimpleNucleiRemote
[nameserver-fingerprint] scanme.sh
--- PASS: TestSimpleNucleiRemote (3.00s)
=== RUN   TestThreadSafeNuclei
=== RUN   TestThreadSafeNuclei/scanme.sh
[INF] Templates clustered: 14 (Reduced 10 Requests)
[nameserver-fingerprint] scanme.sh
[caa-fingerprint] scanme.sh
=== RUN   TestThreadSafeNuclei/honey.scanme.sh
[INF] Templates clustered: 14 (Reduced 10 Requests)
[caa-fingerprint] honey.scanme.sh
--- PASS: TestThreadSafeNuclei (4.29s)
    --- PASS: TestThreadSafeNuclei/scanme.sh (1.18s)
    --- PASS: TestThreadSafeNuclei/honey.scanme.sh (1.02s)
PASS
ok  	github.com/projectdiscovery/nuclei/v3/lib/tests	12.601s

also curious where you using any automated tool for detection or reviewing the codebase ?

@tarunKoyalwar tarunKoyalwar merged commit cb2e652 into projectdiscovery:dev Jul 24, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants