feat(http): assign customHeaders to the map directly

[dwisiswant0]

Proposed changes

Fix #5288.

[...] also add skip expr if header key is "Host".

Proof

As in the doc, "[...] To use non-canonical keys, assign to the map directly".

Template:

# headers-case-sensitive.yaml

id: test

info:
  name: test
  author: dwisiswant0
  severity: info
  description: test
  tags: test

http:
  - method: GET
    path:
      - "{{BaseURL}}/"
    headers:
      x-request-type: base
  - raw:
      - |
        GET / HTTP/1.1
        Host: {{Hostname}}
        x-request-type: raw

Command

go run cmd/nuclei/main.go -H "foo: bar" -H "lOrem: iPsum" -t headers-case-sensitive.yaml -u https://scanme.sh -debug-req

Output

Before:

[INF] [test] Dumped HTTP request for https://scanme.sh/

GET / HTTP/1.1
Host: scanme.sh
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.1.2 Mobile/15E148 Safari/604.1
Connection: close
Accept: */*
Accept-Language: en
Foo: bar
Lorem: iPsum
x-request-type: base
Accept-Encoding: gzip

[INF] [test] Dumped HTTP request for https://scanme.sh

GET / HTTP/1.1
Host: scanme.sh
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.2.19
Connection: close
Foo: bar
Lorem: iPsum
x-request-type: raw
Accept-Encoding: gzip

[INF] No results found. Better luck next time!

After:

[INF] [test] Dumped HTTP request for https://scanme.sh/

GET / HTTP/1.1
Host: scanme.sh
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 14_3_1) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.3.1 Safari/605.1.15
Connection: close
Accept: */*
Accept-Language: en
foo: bar
lOrem: iPsum
x-request-type: base
Accept-Encoding: gzip

[INF] [test] Dumped HTTP request for https://scanme.sh

GET / HTTP/1.1
Host: scanme.sh
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_5_1) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.1 Safari/605.1.15
Connection: close
foo: bar
lOrem: iPsum
x-request-type: raw
Accept-Encoding: gzip

[INF] No results found. Better luck next time!

Checklist

• Pull request is created against the dev branch
• All checks passed (lint, unit/integration/regression tests etc.) with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[dwisiswant0]

Anyone can answer https://github.com/projectdiscovery/nuclei/pull/5445/files#diff-74de151d167a5a2baddd58e1147646f15613a65f9e19645a8a54e8895a55f096R1086-R1087?

[tarunKoyalwar]

lgtm!
@dwisiswant0 any specific reason we would want to convert them to lower case ?

if you meant converting kk during comparison ex:

if strings.ToLower(kk) == "Host" 

we can do that as well as extra validation

[dwisiswant0]

if you meant converting kk during comparison ex:

That's correct.