Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isPortOpen: use fastdialer instance #5452

Merged
merged 1 commit into from
Jul 26, 2024
Merged

isPortOpen: use fastdialer instance #5452

merged 1 commit into from
Jul 26, 2024

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Jul 26, 2024 •
edited
Loading

Proposed Changes

Fastdialer implements many optimizations and follows timeout specified by -timeout flag along with other extra options like allowlist etc but earlier in isPortOpen and isUDPPortOpen helper functions we were using net.Dial which causes inconsistencies and issues

@tarunKoyalwar tarunKoyalwar self-assigned this Jul 26, 2024
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review July 26, 2024 12:05
@tarunKoyalwar tarunKoyalwar changed the base branch from dev to issue-5449-missing-ms July 26, 2024 15:11
@tarunKoyalwar
Copy link
Member Author

will be merged to other pr and combinely reviewed

@tarunKoyalwar tarunKoyalwar merged commit e2bcdc3 into issue-5449-missing-ms Jul 26, 2024
9 of 12 checks passed
@tarunKoyalwar tarunKoyalwar deleted the issue-5451-dialer-issue branch July 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

@dwisiswant0 dwisiswant0 Awaiting requested review from dwisiswant0

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isPortOpen dialer timeout issue
1 participant
@tarunKoyalwar