Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vars with SDK #5678

Merged

Conversation

alban-stourbe-wmx
Copy link
Contributor

@alban-stourbe-wmx alban-stourbe-wmx commented Sep 30, 2024

Proposed changes

Add a new SDK function called WithVars which allows to loaded variables.

Closes #5803

Checklist

  • Pull request is created against the dev branch
  • [] All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-assign auto-assign bot requested a review from dogancanbakir September 30, 2024 14:55
@alban-stourbe-wmx
Copy link
Contributor Author

@dogancanbakir some checks failed but it seems to me that my PR is not involved in the failure

@alban-stourbe-wmx
Copy link
Contributor Author

Can i have an update ? i need it please ;) @dogancanbakir

@alban-stourbe-wmx
Copy link
Contributor Author

:) @ehsandeep

@dogancanbakir dogancanbakir merged commit 7547f1a into projectdiscovery:dev Nov 8, 2024
17 of 22 checks passed
@dogancanbakir
Copy link
Member

@alban-stourbe-wmx I merged the PR, but it might take a while to release this, fyi.

@alban-stourbe-wmx
Copy link
Contributor Author

@alban-stourbe-wmx I merged the PR, but it might take a while to release this, fyi.

How many times do u think ?

@dogancanbakir
Copy link
Member

It depends on the need/fixes/time. So, there is no specific timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WithVars func in SDK
2 participants