Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(sdk): sdk functions to access workflow store #5766

Merged
merged 1 commit into from
Oct 25, 2024
Merged

perf(sdk): sdk functions to access workflow store #5766

merged 1 commit into from
Oct 25, 2024

Conversation

iuliu8899
Copy link
Contributor

@iuliu8899 iuliu8899 commented Oct 24, 2024 •
edited
Loading

Proposed changes

link

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-assign auto-assign bot requested a review from dwisiswant0 October 24, 2024 09:07
@dwisiswant0
Copy link
Member

Why it's perf?

@iuliu8899
Copy link
Contributor Author

Why it's perf?

ok it's feat? idk

@dogancanbakir dogancanbakir linked an issue Oct 25, 2024 that may be closed by this pull request
[FEATURE] sdk functions to access workflows & store #5765
Closed
@dogancanbakir dogancanbakir requested review from ehsandeep and tarunKoyalwar and removed request for ehsandeep October 25, 2024 12:40
tarunKoyalwar
tarunKoyalwar approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@tarunKoyalwar tarunKoyalwar merged commit 88b460c into projectdiscovery:dev Oct 25, 2024
12 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 21, 2024
Merged
@blsaccess blsaccess mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@dwisiswant0 dwisiswant0 Awaiting requested review from dwisiswant0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] sdk functions to access workflows & store
3 participants
@iuliu8899 @dwisiswant0 @tarunKoyalwar