-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avatar decorations #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits + please update the TS definitions (if you aren't able to, let me know and I'll update them for you), otherwise it's good to go once the appropriate docs PR is merged
Hey there! 👋 If this PR is still alive, then it might be worth refactoring it to the latest iteration: discord/discord-api-docs#6464 That one is going to stay for a while, I think. Whereas the ones seen before seemed to be seasonal testing rounds… |
Will refactor with the latest iteration later this weekend. |
Sidenote: I removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks, otherwise, LGTM
c030537
to
ff05e99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, I rebased the branch on top of latest dev, please keep that in mind if you'd like to change something more.
ff05e99
to
665960e
Compare
just a tiny nit :)
…the rest of types
943ea1c
to
a31749e
Compare
Ref:
discord/discord-api-docs#5723discord/discord-api-docs#6464This also is based on new seasonal avatar decorations being prefixed withv2_
to denote using an avatar decoration preset.