Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant keys can now be numbers, identifiers or quoted text #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stasm
Copy link
Contributor

@stasm stasm commented May 22, 2018

Currently, variant keys can either be numbers (NumberExpressions) or text (VariantNames). Text keys allow inline whitespace; the whitespace at the extremes, however, is trimmed. Special characters like { or [ are forbidden, but no escape sequences are allowed either.

This PR changes variant keys to now be numbers (as before), identifiers (Identifier) or quoted text (StringExpressions). The VariantName AST node has been removed.

Fixes #90.

@stasm stasm force-pushed the remove-variant-names branch from f4a11ad to 26ec384 Compare May 22, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant