Added hash only mode for compairing files. Fixed verbose logging. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,5 +19,14 @@ public static string ComputeSha1(this FileInfoBase file) | |||
| return BitConverter.ToString(sha1.ComputeHash(fileStream)); | |||
| } | |||
| } | |||
|
|
|||
| public static string ComputeSha256(this FileInfoBase file) | |||
There was a problem hiding this comment.
Given non-security related scenario, isn't the existing Sha1 method sufficient?
Set max log lines to 100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a script that runs after a build which copies all our assemblies to a shared bin folder. This is where we prefer to deploy from. Unfortunately, this process resets all the dates on the files, so Kudusync think every single file is new. By comparing the file hash, and in conjunction with the MSBUILD /deterministic parameter, it is possible to compare the hashes of dll files, to determine if they have changed since the last build. I added a command line option to enable hash only mode, while leaving the existing timestamp comparison feature intact.
I also noticed that verbose logging was not working, so that was fixed as well. Also overrode the logger to copy its output to the debug console, to assist in debugging.