fill param values from query #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slingshot.Api/ng/Scripts/app.js
Outdated
| startIndex = query.indexOf(token); | ||
|
|
||
| if (startIndex >= 0) { | ||
| return query.substring(startIndex + token.length); |
There was a problem hiding this comment.
I can't even make sense of this old code. If I read it correctly, it only works if there is a single item on query string? Is that why you had to rewrite it?
|
The change seems solid. Were you able to test it? |
|
Not yet able to test the change, still blocked on localhost login flow, tried Edge, IE, Chrome. (none worked, and oddly Edge private mode won't even recognize https://localhost:443006 as valid web address) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows deploy button link to contain extras query param to prefill template parameters