fix(release): use commit-and-tag-version instead of deprecated standard-version #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/commit-and-tag-version
branch
from
0a27076
to
288635d
Compare
Signed-off-by: github-actions <[email protected]>
Co-authored-by: Eli Polonsky <[email protected]>
mrgrain
commented
Aug 26, 2024
Signed-off-by: github-actions <[email protected]>
Signed-off-by: github-actions <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
Fixes #3806 The PR #3801 modified the `Version` class by moving the addition of the version bump dependency from `NodeProject` to `Version`. While this makes sense intuitively, the `Version` class was previously written in a way that could be run against any project type provided the running environment had npx installed The fix is to only add the `bumpPackage` dependency when we have a `NodePackage` available. Also adds a test and comment to prevent a future regression. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the deprecated standard-version with the drop-in fork commit-and-tag-version.
Fixes a lot of outdated dependencies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.