-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final - Select range #315
Merged
Merged
Final - Select range #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix - issue with arrow not enable when setting maxDate
Release 1.3.0
…ial-calendarview into papageorgiouk-range-select
This was referenced May 21, 2016
Awesome! Happy to have contributed to such a useful project. Cheers and keep up the good work. If there's anything else I can do, I'd be more than happy to oblige. |
switch (mode) { | ||
case SELECTION_MODE_MULTIPLE: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SELECTION_MODE_MULTIPLE
shouldn't be removed, this is breaking selection mode multiple
@ekchang All good now |
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As from @papageorgiouk PR, here is a final version of the select range feature.
SELECTION_MODE_RANGE
SELECTION_MODE_NONE
)@papageorgiouk feel free to review my final version. Credit as well to @damian-aragunde-udc for helping with this.
@ekchang @chahinem @Jogan