Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-rabbitmq-exporter] upgrade to 1.0.0 #5100

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

DrFaust92
Copy link
Contributor

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@DrFaust92 DrFaust92 changed the title [prometheus-rabbitmq-exporter] upgrade to 1.0.0 [prometheus-rabbitmq-exporter] upgrade to 1.0.0 - WIP Dec 26, 2024
@DrFaust92 DrFaust92 changed the title [prometheus-rabbitmq-exporter] upgrade to 1.0.0 - WIP [prometheus-rabbitmq-exporter] upgrade to 1.0.0 Dec 26, 2024
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme should contain upgrade instructions /& explanation why the major upgrade.

@DrFaust92
Copy link
Contributor Author

monotek added, a major image version change requires a bump in chart image to reflect possible upstream breaking changes

@DrFaust92 DrFaust92 requested a review from monotek December 27, 2024 07:37
@DrFaust92
Copy link
Contributor Author

monotek can we move this?

@DrFaust92 DrFaust92 force-pushed the rabbitmq-1.0.0 branch 2 times, most recently from 5d8d198 to aea0dac Compare January 19, 2025 01:20
DrFaust92 and others added 4 commits January 21, 2025 08:33
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: Ilia Lazebnik <[email protected]>
Signed-off-by: André Bauer <[email protected]>
@monotek monotek merged commit c30a208 into prometheus-community:main Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants