-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for IncludeLinkedAccounts Options #1466
base: master
Are you sure you want to change the base?
Conversation
@cristiangreco could you help taking a look at this? if you have other idea how to do this, please let us know. we will update accordingly. |
@cristiangreco friendly ping. could you take a look at this? |
5bb4f5d
to
1b33efc
Compare
@cristiangreco anything we need to update to get this in? |
@cristiangreco Any update on this? It is really needed. |
This PR needs to be rebased before it can be reviewed. Additionally, please extend the documentation to i) describe the new config option and ii) describe more generally why/when this is useful. |
cb058f0
to
2ef0cd1
Compare
@cristiangreco Can this be deployed? |
@tuananh Thank you for the effort ! Anything we can help to get this merged in ? We really need it. |
We need @cristiangreco to take a look at it. Or if he has idea for another way of doing, we're happy to update the PR accordingly. We've been using this feature in-house because we need it for our aws org. Would be nice to have it merged upstream. |
Hi, it is not clear to me how this problem is addressed:
From #861 (comment) |
Only metric data is obtained and no resource tags from linked accounts. For logic getting tagged resources, I return nil when enabling config IncludeLinkedAccounts, since querying resource tags from linked accounts requires more permissions in AWS cross-account. |
This means that the metric data you get back is not associated with the correct resource? How's that useful? (genuine question) |
I think the metrics data (metrics and dimensions) from cloudwatch is enough for us. For linked accounts, no metrics _info of each resource is acceptable, we haven't used these _info metrics yet. Currently, we only clone the dashboard from cloudwatch to Grafana. Example: |
Add support for IncludeLinkedAccounts Options
Related to #861