Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-discovery for Directory Services(MicrosoftAD) #757 #1556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add auto-discovery for Directory Services(MicrosoftAD) #757 #1556

wants to merge 1 commit into from

Conversation

RuslanMustaev
Copy link

For the feature request #757

@RuslanMustaev RuslanMustaev force-pushed the feature/auto-discovery-for-directory-services branch 4 times, most recently from bec657b to 4becfcd Compare November 17, 2024 20:37
@RuslanMustaev RuslanMustaev changed the title Add auto-discovery for Directory Services(MicrosoftAD) #757 git logAdd auto-discovery for Directory Services(MicrosoftAD) #757 Nov 17, 2024
@RuslanMustaev RuslanMustaev changed the title git logAdd auto-discovery for Directory Services(MicrosoftAD) #757 Add auto-discovery for Directory Services(MicrosoftAD) #757 Nov 17, 2024
@RuslanMustaev RuslanMustaev force-pushed the feature/auto-discovery-for-directory-services branch from 133d7cd to f835fdd Compare November 17, 2024 22:42
cristiangreco
cristiangreco reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@cristiangreco cristiangreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind adding a test like pkg/job/maxdimassociator/associator_api_gateway_test.go?

@RuslanMustaev RuslanMustaev reopened this Nov 27, 2024
@RuslanMustaev
Copy link
Author

Thanks! Do you mind adding a test like pkg/job/maxdimassociator/associator_api_gateway_test.go?

Sure, will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiangreco cristiangreco cristiangreco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuslanMustaev @cristiangreco