Added custom overrides for kube-rbac-proxy-self. #1637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have discovered that kube-state-metrics tends tends to experience CPU throttling in my kubernetes cluster. I want to get CPU throttling down to a decent level below 10%. Right now I don't have a way to change this.
This is a picture from my cluster. The sidecar called kube-rbac-proxy-self experiences a CPU throttling of 19%. This gives bad performance
I use thanos along prometheus.
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
By looking at existing code I am extending kube-rbac-proxy-self with the same set of overrides as a similar sidecar container kube-rbac-proxy-main. This way I get a pitch point where i can add more CPU resources to the container.
Test and Verification
Edit the file called examples/kustomize.jsonnet. Add the following block at line 7.
Run the install procedures from README.md followed by the generate procedure from github actions.
jb install github.com/ahysing/kube-prometheus/jsonnet/kube-prometheus@custom-requests-kube-rbacc-proxy-self make --always-make generate validate && git diff --exit-code
Make sure that the file manifests/kubeStateMetrics-deployment.yaml is changed properly with the new limits you expected.