Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2 #2259

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Patch 2 #2259

merged 3 commits into from
Nov 7, 2023

Conversation

m99coder
Copy link
Contributor

@m99coder m99coder commented Nov 1, 2023

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Fix typo in the error message for a missing image config field for node-exporter, blackbox-exporter, and windows-hostprocess

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.

- Fix typo in the error message for a missing `image` config field for `node-exporter`, `blackbox-exporter`, and `windows-hostprocess`

@m99coder
Copy link
Contributor Author

m99coder commented Nov 1, 2023

Sorry for not having directly checked each file for the same typo 🙈

@philipgough philipgough merged commit ad86a3f into prometheus-operator:main Nov 7, 2023
10 checks passed
@m99coder m99coder deleted the patch-2 branch November 8, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants