Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script/generate-versions: fix versions sort #2294

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

dgrisonnet
Copy link
Contributor

Description

I was wondering why kube-state-metrics wasn't updated from v2.9.2 to v2.10.z despite these new releases out for a couple a few months, and it seems that the script was buggy.

Instead of using -n option we should use -V which is meant for sorting versions.

~ printf '%s\n' "9" "10" | sort -V -r 
10
9
➜  ~ printf '%s\n' "2.9.2" "2.10.1" | sort -V -r
2.10.1
2.9.2

This new version also fixes the problem reported in #2261.

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.


@dgrisonnet
Copy link
Contributor Author

cc @philipgough

If this change didn't make it to the next trigger of the script, would you mind to retrigger it manually? 🙇

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philipgough philipgough merged commit 2799245 into prometheus-operator:main Dec 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants