Add more checks around summaries and histograms #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2018 13:43
Also, document the existing behavior more clearly. Signed-off-by: beorn7 <[email protected]>
Including check for an invalid "quantile" label in summaries. Also, improve error messages. Signed-off-by: beorn7 <[email protected]>
So far, if a gauge was named `xxx_count`, and a summary or histogram `xxx`, this would have led to a legal protobuf exposition but would have created a name collision on `xxx_count` in the text format and within the Prometheus server. Signed-off-by: beorn7 <[email protected]>
grobie
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108 .
@grobie