fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5, add unit test #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "show slave hosts" command on mysql 5.5 and mariadb 10.5 returns neither a "Slave_UUID" nor a "Rpl_recovery_rank" column. Set the slave_uuid metric label to "" in this case. Signed-off-by: Felix Hamme <[email protected]>
betanummeric
force-pushed
the
fix-show-slave-hosts
branch
from
3347e21 to
5132a1c
Compare
SuperQ
added a commit
that referenced
this pull request
Jan 5, 2022
BREAKING CHANGES: Metric names in the info_schema.processlist collector have been changed. #603 Metric names in the info_schema.replica_host collector have been changed. #496 * [CHANGE] Rewrite processlist collector #603 * [FEATURE] Add collector for `replica_host_status` #496 * [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561 * [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577 * [BUGFIX] Fix logging issues #562 #602 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Mar 3, 2022
BREAKING CHANGES: Metric names in the info_schema.processlist collector have been changed. #603 Metric names in the info_schema.replica_host collector have been changed. #496 * [CHANGE] Rewrite processlist collector #603 * [FEATURE] Add collector for `replica_host_status` #496 * [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561 * [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577 * [BUGFIX] Fix logging issues #562 #602 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Mar 3, 2022
BREAKING CHANGES: Metric names in the info_schema.processlist collector have been changed. #603 Metric names in the info_schema.replica_host collector have been changed. #496 * [CHANGE] Rewrite processlist collector #603 * [FEATURE] Add collector for `replica_host_status` #496 * [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561 * [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577 * [BUGFIX] Fix logging issues #562 #602 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Mar 3, 2022
BREAKING CHANGES: Metric names in the info_schema.processlist collector have been changed. #603 Metric names in the info_schema.replica_host collector have been changed. #496 * [CHANGE] Rewrite processlist collector #603 * [FEATURE] Add collector for `replica_host_status` #496 * [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561 * [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577 * [BUGFIX] Fix logging issues #562 #602 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Mar 4, 2022
BREAKING CHANGES: Metric names in the info_schema.processlist collector have been changed. #603 Metric names in the info_schema.replica_host collector have been changed. #496 * [CHANGE] Rewrite processlist collector #603 * [FEATURE] Add collector for `replica_host_status` #496 * [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561 * [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577 * [BUGFIX] Fix logging issues #562 #602 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #422
The
show slave hostscommand on mysql 5.5 and mariadb 10.5 returns neither aSlave_UUIDnor aRpl_recovery_rankcolumn. Set theslave_uuidmetric label to""in this case.The unit test is copied from
TestScrapeSlaveHostsNewFormat, with the mocked and expected rows amended. I also tested this with real MySQL 5.5.62, MySQL 5.7.33 and MariaDB 10.5.10 servers.@SuperQ Can you please review this pull request? If I missed something, please let me know.