This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Next - highlight: deploy the versioning workflows to all repos #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent go-car PR, we noticed that codecov was complaining about an uncovered line, when it was definitely being covered by a test. The problem was that the test was in another package. We could be strict and only count coverage within each package. However, what's most useful is to count the aggregate coverage across all packages in a module. If a module only achieves 70% coverage within each of its packages, but achieves 90% coverage when including cross-package coverage, the latter number is what is actually most interesting to us. Achieving full coverage within each package is perhaps ideal, but certainly not a requirement to have good coverage. Plus, this change will reduce "uncovered line" noise that can be reasonably considered a false positive.
include cross-package coverage in codecov
update Codecov action to v2.1.0
update staticcheck to 2021.1.2 (v0.2.2)
make it possible to cut release on non-default branches
* chore: add ipfs/go-ds-sql * sorted config.json alphabetically Co-authored-by: Piotr Galar <[email protected]>
GitHub Actions finally fixed the issue, see actions/runner#834 (comment). This reverts #202.
alternative: use msys2 on Windows
deploy the versioning workflows to all repos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #240 (comment) What existing Slack channel would be good for such heads up? I was thinking
#w3dt-unified-cibut there are not many people there. However, I think it might be enough to just have a message we can link to there given that @marten-seemann already did the main announcement during the Demo Day 💪📢 Changes in this release