Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoding of signed varint32s. #134

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Fix decoding of signed varint32s. #134

merged 2 commits into from
Sep 19, 2022

Conversation

varomodt
Copy link
Contributor

@varomodt varomodt commented Sep 9, 2022

This fixes #31

@varomodt varomodt marked this pull request as ready for review September 9, 2022 23:28
lukesandberg
lukesandberg reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@lukesandberg lukesandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a unit test for this issue

@varomodt varomodt merged commit b545ac8 into protocolbuffers:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesandberg lukesandberg lukesandberg approved these changes

Assignees

@lukesandberg lukesandberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

int32 negative value turn into highest value int32 = 4294967295
2 participants
@varomodt @lukesandberg