Skip to content

Commit

Permalink
Whitespace fixes and an attempt at fix for Windows Python Release (CM…
Browse files Browse the repository at this point in the history
…ake version < 3.13)
  • Loading branch information
mkruskal-google committed Apr 15, 2022
1 parent da19870 commit 487223c
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,7 @@ EXTRA_DIST = $(@DIST_LANG@_EXTRA_DIST) \
BUILD \
WORKSPACE \
CMakeLists.txt \
cmake/abseil-cpp.cmake \
cmake/abseil-cpp.cmake \
cmake/CMakeLists.txt \
cmake/README.md \
cmake/conformance.cmake \
Expand Down
2 changes: 1 addition & 1 deletion kokoro/release/python/linux/build_artifacts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ git clone https://github.com/matthew-brett/multibuild.git
# silently creeping in (see https://github.com/protocolbuffers/protobuf/issues/9180).
# IMPORTANT: always pin multibuild at the same commit for:
# - linux/build_artifacts.sh
# - linux/build_artifacts.sh
# - macos/build_artifacts.sh
# - windows/build_artifacts.bat
(cd multibuild; git checkout b89bb903e94308be79abefa4f436bf123ebb1313)
cp kokoro/release/python/linux/config.sh config.sh
Expand Down
2 changes: 1 addition & 1 deletion kokoro/release/python/macos/build_artifacts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ git clone https://github.com/matthew-brett/multibuild.git
# silently creeping in (see https://github.com/protocolbuffers/protobuf/issues/9180).
# IMPORTANT: always pin multibuild at the same commit for:
# - linux/build_artifacts.sh
# - linux/build_artifacts.sh
# - macos/build_artifacts.sh
# - windows/build_artifacts.bat
(cd multibuild; git checkout b89bb903e94308be79abefa4f436bf123ebb1313)
cp kokoro/release/python/macos/config.sh config.sh
Expand Down
7 changes: 6 additions & 1 deletion kokoro/release/python/windows/build_artifacts.bat
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ REM Pin multibuild scripts at a known commit to avoid potentially unwanted futur
REM silently creeping in (see https://github.com/protocolbuffers/protobuf/issues/9180).
REM IMPORTANT: always pin multibuild at the same commit for:
REM - linux/build_artifacts.sh
REM - linux/build_artifacts.sh
REM - macos/build_artifacts.sh
REM - windows/build_artifacts.bat
cd multibuild
git checkout b89bb903e94308be79abefa4f436bf123ebb1313
Expand All @@ -34,6 +34,11 @@ SET ZLIB_ROOT=%cd%\zlib
del /Q zlib.zip
del /Q zlib-src.zip

REM Install Abseil
mkdir absl
git clone https://github.com/abseil/abseil-cpp.git
SET ABSL_ROOT_DIR=%cd%\abseil-cpp

REM Create directory for artifacts
SET ARTIFACT_DIR=%cd%\artifacts
mkdir %ARTIFACT_DIR%
Expand Down
1 change: 1 addition & 0 deletions src/google/protobuf/message.h
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@
#include <google/protobuf/map.h> // TODO(b/211442718): cleanup
#include <google/protobuf/message_lite.h>


This comment has been minimized.

Copy link
@fowles

fowles Apr 15, 2022

Contributor

seems unneeeded

This comment has been minimized.

Copy link
@mkruskal-google

mkruskal-google via email Apr 15, 2022

Author Member

This comment has been minimized.

Copy link
@fowles

fowles Apr 15, 2022

Contributor

the extra newline that you added right here.

This comment has been minimized.

Copy link
@mkruskal-google

mkruskal-google Apr 15, 2022

Author Member

Whoops, yea I was just adding this back after accidentally deleting it (scar left from my test run)

// Must be included last.
#include <google/protobuf/port_def.inc>

Expand Down

0 comments on commit 487223c

Please sign in to comment.