-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #10007: Propagate msvc-style link flags to clang-cl with Bazel
The idea here is to set the existing config "config_msvc" not only when "msvc-cl" is specified but also when "clang-cl" is specified. Keep in mind that clang-cl support in protobuf remains to be only best-effort and untested for now. PiperOrigin-RevId: 631195504
- Loading branch information
1 parent
4c8da99
commit 55592a2
Showing
1 changed file
with
15 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,10 +14,24 @@ package( | |
) | ||
|
||
create_compiler_config_setting( | ||
name = "config_msvc", | ||
This comment has been minimized.
Sorry, something went wrong. |
||
name = "config_msvc_cl", | ||
value = "msvc-cl", | ||
) | ||
|
||
# Caveat: clang-cl support in protobuf is only best-effort / untested for now. | ||
create_compiler_config_setting( | ||
name = "config_clang_cl", | ||
value = "clang-cl", | ||
) | ||
|
||
selects.config_setting_group( | ||
name = "config_msvc", | ||
match_any = [ | ||
":config_clang_cl", | ||
":config_msvc_cl", | ||
], | ||
) | ||
|
||
config_setting( | ||
name = "aarch64", | ||
values = {"cpu": "linux-aarch_64"}, | ||
This comment has been minimized.
Sorry, something went wrong.
pullenmils35
|
||
|
put brackets around "config_msvc" it makes it not a open file sourcing out to find what it needs to confirm name. where as config_msvc_cl is a secondary file that can source out till coming to conclusion