Skip to content

Commit

Permalink
Add missing generated file (#15693)
Browse files Browse the repository at this point in the history
The proto file is required for Java test. Otherwise it fails with

```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile (default-testCompile) on project protobuf-java: Compilation failure: Compilation failure:
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[46,25] cannot find symbol
[ERROR]   symbol:   class UnittestRetention
[ERROR]   location: package protobuf_unittest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[550,27] cannot find symbol
[ERROR]   symbol:   variable UnittestRetention
[ERROR]   location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[551,37] cannot find symbol
[ERROR]   symbol:   variable UnittestRetention
[ERROR]   location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[552,37] cannot find symbol
[ERROR]   symbol:   variable UnittestRetention
[ERROR]   location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[553,37] cannot find symbol
[ERROR]   symbol:   variable UnittestRetention
[ERROR]   location: class com.google.protobuf.DescriptorsTest
[ERROR] -> [Help 1]
```

Closes #15693

COPYBARA_INTEGRATE_REVIEW=#15693 from jpechane:add-missing-file 9293fab
PiperOrigin-RevId: 604518500
  • Loading branch information
jpechane authored and copybara-github committed Feb 6, 2024
1 parent 5d4fd7e commit c98bdc2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions java/core/generate-test-sources-build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<arg value="${protobuf.source.dir}/google/protobuf/unittest_optimize_for.proto"/>
<arg value="${protobuf.source.dir}/google/protobuf/unittest_proto3.proto"/>
<arg value="${protobuf.source.dir}/google/protobuf/unittest_proto3_optional.proto"/>
<arg value="${protobuf.source.dir}/google/protobuf/unittest_retention.proto"/>
<arg value="${protobuf.source.dir}/google/protobuf/unittest_well_known_types.proto"/>
<arg value="${test.proto.dir}/com/google/protobuf/any_test.proto"/>
<arg value="${test.proto.dir}/com/google/protobuf/cached_field_size_test.proto"/>
Expand Down

0 comments on commit c98bdc2

Please sign in to comment.