Skip to content

Commit

Permalink
Update upb dep to the latest 23.x commit (#13215)
Browse files Browse the repository at this point in the history
* Update upb dep to the latest 23.x commit

* Fix objectivec test failure in Bazel 6+.

This fix works in Bazel 5 and 6, but the original `import pddm` only works in Bazel 5.  This is preventing our upgrade to Bazel 6 that will reduce our mac flakes in CI.

PiperOrigin-RevId: 543565397

* Bump heap size for linkage monitor tests
  • Loading branch information
mkruskal-google authored Jul 5, 2023
1 parent 571fae4 commit da85a3a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test_java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Download Linkage Monitor
run: curl -v -O "https://storage.googleapis.com/cloud-opensource-java-linkage-monitor/linkage-monitor-latest-all-deps.jar"
- name: Fails if there's new linkage errors compared with baseline
run: java -Xmx2048m -jar linkage-monitor-latest-all-deps.jar com.google.cloud:libraries-bom
run: java -Xmx4096m -jar linkage-monitor-latest-all-deps.jar com.google.cloud:libraries-bom

protobuf-bom:
name: Protobuf Maven BOM
Expand Down
2 changes: 1 addition & 1 deletion objectivec/DevTools/pddm_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import io
import unittest

import pddm
from objectivec.DevTools import pddm


class TestParsingMacros(unittest.TestCase):
Expand Down
4 changes: 2 additions & 2 deletions protobuf_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def protobuf_deps():
_github_archive(
name = "upb",
repo = "https://github.com/protocolbuffers/upb",
commit = "1956df14832979471d0c79210a817aeb54f7a526",
sha256 = "102039feae921205690d28561d6c74ba13e0561a76d7247de5df7d7cc8d72ca6",
commit = "455cfdb8ae60a1763e6d924e36851c6897a781bb",
sha256 = "2c8b4e961c38fcc7c58e8aca807cc3cc5190f42afdf39551ce49812b130493de",
patches = ["@com_google_protobuf//build_defs:upb.patch"],
)

0 comments on commit da85a3a

Please sign in to comment.