Add go_package statements for the Go-supported WKTs. #1361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like #1365 got abandoned because of some other problems. Can we merge this one now? It's causing a bit of pain elsewhere. |
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test. |
This instructs the Go protobuf code generator how to generate code in the right place and generate correct import statements. The design for this feature is described in golang/protobuf#139. This is an integration of a Google-internal change.
|
ok to test |
|
Is there anything still blocking this? |
|
@xfxyjwf, please merge? |
|
I think the other integration has already been merged. See https://github.com/google/protobuf/blob/master/src/google/protobuf/any.proto |
|
Indeed, thanks. |
dstore-dbap
pushed a commit
to dstore-io/dstore-sdk-golang
that referenced
this pull request
Jun 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instructs the Go protobuf code generator how to generate code in the right
place and generate correct import statements. The design for this feature is
described in golang/protobuf#139.
This is an integration of a Google-internal change.