PHP: fix ZTS tsrm_ls errors #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
TeBoring
force-pushed
the
3.1.x
branch
15 times, most recently
from
0676502 to
bcb32c0
Compare
|
Do I need to recompile PHP or just protobuf's extension with enable-maintainer-zts? |
|
Is there any command line to install php with zts? |
|
As far as I know, you need to re-compile PHP with |
TeBoring
force-pushed
the
3.1.x
branch
2 times, most recently
from
8173ab1 to
858db7a
Compare
|
ok to test |
|
php/ext/google/protobuf/array.c:163:8: error: too few arguments to function 'native_slot_set' |
|
jenkins is able to test zts build now. |
|
LGTM |
TeBoring
pushed a commit
to TeBoring/protobuf
that referenced
this pull request
Oct 10, 2016
* PHP: fix ZTS tsrm_ls errors * Fix a few more macros
dand-oss
pushed a commit
to dand-oss/protobuf
that referenced
this pull request
Nov 11, 2016
* PHP: fix ZTS tsrm_ls errors * Fix a few more macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2186
To reproduce:
./configure --enable-maintainer-zts