First attempt at using profile 259 for Google.Protobuf. #638

jskeet · 2015-07-23T14:32:57Z

This requires .NET 4.5, and there are a few compatibility changes required around reflection.
Creating a PR from this to see how our CI systems handle it. Will want to add more documentation,
validation and probably tests before merging.

This is in aid of issue #590.

@jtattermusch FYI

jtattermusch · 2015-07-25T01:22:14Z

Interesting stuff, let me know when this is ready to be reviewed. By dropping .NET 4 support, are we expecting do disqualify some user group from using C# protobufs?
Btw, how about Unity? I've never used it but I think it uses some ancient version of .NET.

jskeet · 2015-07-25T06:13:40Z

I'm not worried by Windows desktop users - the vast, vast majority will be on 4.5 by now.
Unity is a good point though - will investigate over the weekend.

This requires .NET 4.5, and there are a few compatibility changes required around reflection. Creating a PR from this to see how our CI systems handle it. Will want to add more documentation, validation and probably tests before merging. This is in aid of issue protocolbuffers#590.

jskeet · 2015-07-27T16:51:32Z

I think it'll be worth tidying up this PR in terms of documentation, then merging it.

I suspect it won't work with Unity, but we can add another build target for that later when we find a need - we can create a new minor version of the NuGet package for that with no problems. My experience with the "old" port is that Unity on iOS has various issues, so I think we'll want to investigate them pretty thoroughly before trying to support it anyway - and we may need to conditionally compile out some features. We'll see... but I'd like to avoid having Unity support block a dotnetcore release.

I'll add the docs and tests to this PR tomorrow (UK time).

jskeet · 2015-07-27T16:52:25Z

Having said that, this Travis failure is none too promising:

++mono ../../nuget.exe restore
Native stacktrace:
mono() [0x4b20bc]
mono() [0x5086ee]
mono() [0x428f7d]
/lib/x86_64-linux-gnu/libpthread.so.0(+0xfcb0) [0x7f6232ea7cb0]
mono() [0x517335]
mono() [0x524a00]
mono() [0x4b4898]
[0x41445046]

Debug info from gdb:

Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries

used by your application.

jtattermusch · 2015-07-27T18:39:12Z

That's a flake in nuget + mono combo I've seen happening in the past, but it doesn't happen very often. So my guess is after rerunning the test you'll be fine (and this flake is probably something we'll have to live with).

jtattermusch · 2015-07-27T18:41:14Z

csharp/src/Google.Protobuf.JsonDump/Google.Protobuf.JsonDump.csproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <EnvironmentFlavor>CLIENTPROFILE</EnvironmentFlavor>


do we still need the CLIENTPROFILE declaration?

No, I don't think so. There may be all kinds of stuff in the build file that's left over from more complicated times. Will have a look at that at the same time.

jtattermusch · 2015-07-27T18:45:46Z

Changes LGTM.
Some more nits:
-- one comment above
-- please also update the .nuspec file so that's it's in sync with the changes to profile
-- please update the list of supported platforms in the README.md file

After that, I think we should merge this.

jskeet · 2015-07-27T18:47:42Z

Will do. IIRC, the nuspec file is already in sync with this (and out of sync with the current profile) but I'll check tomorrow.

jskeet · 2015-07-28T06:18:41Z

Hmm... http://blogs.msdn.com/b/lucian/archive/2015/07/27/writing-a-nuget-package-for-vs2015-rtm-and-uwp.aspx suggests there may be more answers in a few days.

- Fix nupec paths - Remove an obsolete part of the JSON build - Add documentation and tests to reflection extension methods, and improve implementations

jskeet · 2015-07-28T07:20:09Z

Right, this is ready for merging after further review. (The implementation has changed, so it's worth a review.)

As preparation for checking that it's likely to work in terms of .NET Core, I'm going to make the same sorts of changes in Noda Time 2.0 and push an alpha release of that, then try using that in a .NET Core project.

jskeet · 2015-07-28T09:24:20Z

Had missed the bit about supported platforms before - I've added an extra section in the csharp/README.md file; I'm not sure whether that's what you meant though... I couldn't see an existing supported platform list to update.

Flavien · 2015-07-29T10:12:22Z

Do you have an ETA of when this will get released to NuGet?

jtattermusch · 2015-07-29T16:19:44Z

csharp/README.md

@@ -22,6 +22,17 @@ Use `protoc` with the `--csharp_out` option to generate C# files in the specifie
 Include these in your C# project, and add a reference to the `Google.Protobuf` project. Currently
 there is no NuGet package for this, but we will be building one as soon as the API is stable.

+Supported platforms


Yes, I suspected we don't have a supported platforms section, it's great you've added it. Thanks!

jtattermusch · 2015-07-29T16:26:07Z

LGTM.

First attempt at using profile 259 for Google.Protobuf.

jtattermusch · 2015-07-29T16:37:16Z

@Flavien We don't have a specific ETA unfortunately, but we are hoping to release this as nuget package soon. Stay tuned.

Flavien · 2015-08-09T13:40:04Z

Thanks. Do you know if that is a matter of days/weeks/months?

jskeet · 2015-08-09T17:40:45Z

I would estimate a small number of weeks, but that's only an estimate.

jtattermusch · 2015-08-09T22:22:07Z

@Flavien I've created an UNOFFICIAL preview nuget package on my personal fork of this repo https://github.com/jtattermusch/protobuf/releases/tag/unofficial20150808

You can download the preview nuget package there and install it locally. Feedback is welcome.

Flavien · 2015-08-20T10:49:38Z

I've tried it, the package runs smoothly with .NET Core. I haven't noticed any issue so far, apart from the fact that apparently Protobuf v2 is no longer supported so I had to migrate my schemas to version 3.

…fers#638

googlebot added the cla: yes label Jul 23, 2015

jskeet force-pushed the portable branch from 0ba37a9 to 0dbd5ec Compare July 27, 2015 15:20

jtattermusch reviewed Jul 27, 2015
View reviewed changes

jtattermusch self-assigned this Jul 27, 2015

jtattermusch mentioned this pull request Jul 27, 2015

Investigate support for Unity #644

Closed

Tweaks to Profile259 support

0802d56

- Fix nupec paths - Remove an obsolete part of the JSON build - Add documentation and tests to reflection extension methods, and improve implementations

jskeet added 2 commits July 28, 2015 09:01

Humbug - previous commit didn't include project file changes :(

9ccc839

Update the readme file to indicate supported platforms

d82ebe4

Flavien mentioned this pull request Jul 28, 2015

Add a project targeting .NET Core #573

Closed

jtattermusch reviewed Jul 29, 2015
View reviewed changes

jtattermusch added a commit that referenced this pull request Jul 29, 2015

Merge pull request #638 from jskeet/portable

74810c6

First attempt at using profile 259 for Google.Protobuf.

jtattermusch merged commit 74810c6 into protocolbuffers:csharp-experimental Jul 29, 2015

jskeet deleted the portable branch July 30, 2015 08:48

google-admin unassigned jtattermusch Aug 21, 2018

xfxyjwf assigned jtattermusch Aug 24, 2018

adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023

Case-sensitively test for legacy group definitions, fixes protocolbuf…

e11012c

…fers#638

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First attempt at using profile 259 for Google.Protobuf. #638

First attempt at using profile 259 for Google.Protobuf. #638

jskeet commented Jul 23, 2015

jtattermusch commented Jul 25, 2015

jskeet commented Jul 25, 2015

jskeet commented Jul 27, 2015

jskeet commented Jul 27, 2015

jtattermusch commented Jul 27, 2015

jtattermusch Jul 27, 2015

jskeet Jul 27, 2015

jtattermusch commented Jul 27, 2015

jskeet commented Jul 27, 2015

jskeet commented Jul 28, 2015

jskeet commented Jul 28, 2015

jskeet commented Jul 28, 2015

Flavien commented Jul 29, 2015

jtattermusch Jul 29, 2015

jtattermusch commented Jul 29, 2015

jtattermusch commented Jul 29, 2015

Flavien commented Aug 9, 2015

jskeet commented Aug 9, 2015

jtattermusch commented Aug 9, 2015

Flavien commented Aug 20, 2015

First attempt at using profile 259 for Google.Protobuf. #638

First attempt at using profile 259 for Google.Protobuf. #638

Conversation

jskeet commented Jul 23, 2015

jtattermusch commented Jul 25, 2015

jskeet commented Jul 25, 2015

jskeet commented Jul 27, 2015

jskeet commented Jul 27, 2015

Debug info from gdb:

used by your application.

jtattermusch commented Jul 27, 2015

jtattermusch Jul 27, 2015

Choose a reason for hiding this comment

jskeet Jul 27, 2015

Choose a reason for hiding this comment

jtattermusch commented Jul 27, 2015

jskeet commented Jul 27, 2015

jskeet commented Jul 28, 2015

jskeet commented Jul 28, 2015

jskeet commented Jul 28, 2015

Flavien commented Jul 29, 2015

jtattermusch Jul 29, 2015

Choose a reason for hiding this comment

jtattermusch commented Jul 29, 2015

jtattermusch commented Jul 29, 2015

Flavien commented Aug 9, 2015

jskeet commented Aug 9, 2015

jtattermusch commented Aug 9, 2015

Flavien commented Aug 20, 2015