Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pragma solidity #48

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Update pragma solidity #48

merged 1 commit into from
Apr 19, 2018

Conversation

D-Nice
Copy link
Contributor

@D-Nice D-Nice commented Apr 19, 2018

  • excludes known solc versions that break said contracts, until
    permanent fix in place.

- excludes known solc versions that break said contracts, until
permanent fix in place.
@axic
Copy link

axic commented Apr 19, 2018

What contracts are broken which need this change?

@bertani bertani merged commit e9421e2 into master Apr 19, 2018
@D-Nice
Copy link
Contributor Author

D-Nice commented Apr 19, 2018

@axic We're currently investigating to figure out the exact culprit, and then will let you know. For now we've taken the precaution of limiting to those versions of solidity, as they are the ones consistently working within all contexts Oraclize is used.

@D-Nice
Copy link
Contributor Author

D-Nice commented Apr 19, 2018

@axic to update you on this, only our browser-solidity fork with Oraclize module on JVM appears affected after internal testing. Any use of Oraclize with it appears to break starting with solidity 0.4.21-nightly.2018.3.6+commit.a9e02acc. Trying to deploy a contract leveraging Oraclize, causes an out of gas error.

Looking at the debugger, it fails when at a CALL opcode, on:
https://github.com/oraclize/ethereum-api/blob/master/oraclizeAPI_0.5.sol#L306
and more specifically:
OAR.getAddress()

with the stack being

0: 0x88ad6e
1: 0x51efaf4c8b3c9afbd5ab9f4bbc82784ab6ef8faa
2: 0x
3: 0xc0
4: 0x4
5: 0xc0
6: 0x20
7: 0xc4
8: 0x38cc4831
9: 0x51efaf4c8b3c9afbd5ab9f4bbc82784ab6ef8faa
10: 0x
11: 0x80
12: 0x3ed
13: 0x
14: 0x1a3
15: 0xa2e62045

at the time

@D-Nice D-Nice deleted the solc_warnings branch July 2, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants