Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken api symlink #96

Merged
merged 1 commit into from
Jul 23, 2019
Merged

fix: broken api symlink #96

merged 1 commit into from
Jul 23, 2019

Conversation

D-Nice
Copy link
Contributor

@D-Nice D-Nice commented Jul 22, 2019

The relative symlink appeared broken and unusable when trying to test something with it on a local linux fs. The following fixes the issue.

Would be useful to confirm that the current version is broken, and that this works on the reviewers fs as well.

@D-Nice D-Nice requested a review from gskapka July 22, 2019 22:10
@D-Nice D-Nice self-assigned this Jul 22, 2019
Copy link
Collaborator

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't even noticed the dead link, but pulling this and switching to this branch does indeed restore it - so LGTM!

@D-Nice D-Nice merged commit 6d56f55 into master Jul 23, 2019
@D-Nice D-Nice deleted the fix/api-symlink branch July 23, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants