-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch from Envoy: exclude emsdk targets for Bazel/gcc. Fixes #149. #150
Conversation
…sm#149. Signed-off-by: Martijn Stevenson <[email protected]>
Sigh, it looks that Also, could you add a daily CI run on schedule to catch those regressions when they happen (see: https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/94497deb683e37c0fc54e252b600de1dd4d47406/.github/workflows/test.yml#L31-L32)? |
Signed-off-by: Martijn Stevenson <[email protected]>
Signed-off-by: Martijn Stevenson <[email protected]>
Updated CI to use recent clang-format and run daily. PTAL. |
Looking at what's going on with addlicense. |
addlicense wants me to add this to every BUILD file. Is that desired?
|
Probably due to google/addlicense#127 |
Signed-off-by: Martijn Stevenson <[email protected]>
Removed BUILD files from addlicense check for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking, but could you split unrelated fixes into a separate PR? Thanks!
No description provided.