PrepareBeaconProposer API #10367
Merged
PrepareBeaconProposer API #10367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var FeeRecipients []common.Address | ||
| var ValidatorIndices []types.ValidatorIndex | ||
| for _, recipientContainer := range request.Recipients { | ||
| FeeRecipients = append(FeeRecipients, common.BytesToAddress(recipientContainer.FeeRecipient)) |
There was a problem hiding this comment.
I think it's worth validating common.BytesToAddress(recipientContainer.FeeRecipient)
| var FeeRecipients []common.Address | ||
| var ValidatorIndices []types.ValidatorIndex | ||
| for _, recipientContainer := range request.Recipients { | ||
| FeeRecipients = append(FeeRecipients, common.BytesToAddress(recipientContainer.FeeRecipient)) |
There was a problem hiding this comment.
Same here. Worth validating common.BytesToAddress(recipientContainer.FeeRecipient)
| var FeeRecipients []common.Address | ||
| var ValidatorIndices []types.ValidatorIndex | ||
| for _, recipientContainer := range request.Recipients { | ||
| if len(recipientContainer.FeeRecipient) != fieldparams.FeeRecipientLength { |
There was a problem hiding this comment.
Why not just do IsHexAddress(common.BytesToAddress(recipientContainer.FeeRecipient)))?
There was a problem hiding this comment.
I can do it that way too will update then.
rauljordan
reviewed
Mar 16, 2022
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { |
There was a problem hiding this comment.
This test should also read from the DB to ensure the expected data was saved
rauljordan
reviewed
Mar 16, 2022
| db := dbutil.SetupDB(t) | ||
| ctx := context.Background() | ||
| proposerServer := &Server{BeaconDB: db} | ||
| _, err := proposerServer.PrepareBeaconProposer(ctx, tt.args.request) |
rauljordan
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
part of #10292
What does this PR do? Why is it needed?
This PR implements the inner workings of https://github.com/ethereum/beacon-APIs/pull/178/files Beacon API to set the prysm config. This cache is then used when calling get execution payload