E2E: fee-recipient evaluator #10528
Merged
E2E: fee-recipient evaluator #10528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, adding more logging temporarily
7 tasks
nisdas
reviewed
Jun 29, 2022
nisdas
reviewed
Jun 29, 2022
nisdas
reviewed
Jun 29, 2022
| publickey := validator.GetPublicKey() | ||
| // calculate deterministic fee recipient using first 20 bytes of public key | ||
| deterministicFeeRecipient := common.HexToAddress(hexutil.Encode(publickey[:fieldparams.FeeRecipientLength])).Hex() | ||
| if deterministicFeeRecipient != account.Hex() && components.DefaultFeeRecipientAddress != account.Hex() { |
There was a problem hiding this comment.
As a last point, is there anyway to differentiate which validator should be running with the default recipients and which validators should not be ? It is possible (ex:some validator bug) , where the validator does not apply the proposer config correctly and just uses the default fee recipient. With this check we wouldn't have anyway to differentiate. If this isn't possible to figure out currently it is fine we can ignore it for now.
There was a problem hiding this comment.
That's a good point was also thinking about it. I'll see if I can think of something for this. There definitely are validators that use the default , will spend more time figuring out why.
nisdas
approved these changes
Jun 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
E2E
relates to #10292
What does this PR do? Why is it needed?
This PR is to provide E2E for the fee-recipient feature #10292 ( only works post merge/bellatrix release) It will check the presence of the fee recipient in the bellatrix block and see if the user receives transactions.