Suggested Fee Recipient : bug fix #10555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Bug
nisdas
reviewed
Apr 21, 2022
Co-authored-by: Nishant Das <[email protected]>
nisdas
approved these changes
Apr 21, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
related to #10489
related to #10292
What does this PR do? Why is it needed?
the default fee recipient from the suggested fee recipient and the fee recipient config flags ( the flags used for setting the fee recipient address for inclusion rewards) were not working correctly due to a missed condition while the parsing of the flag and config file. this resulted in validators mapping to the default system address ( burn address). This was caught in an E2E test and unit tests failed to catch this condition of setting as the burn address. These issues are addressed in this PR by providing a fix and improved unit tests to catch this condition in the future.
A further improvement included in this pr that users should be warned if there are any issues with this setting so a condition was added to log this as a warning to the user.
specific validator to fee address mappings was working prior to this fix, only default fee recipient settings are affected.
suggested fee recipient can still be set on the beacon node ( if you do not provide the configurations through the validator client)
the feature only runs on post bellatrix blocks