fee-recipient: update error log to warn log #10684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
May 13, 2022
| }).Error("Fee recipient not set. Using burn address") | ||
| }).Warn("Fee recipient not set. Using burn address. " + | ||
| "You will not be rewarded transaction fees on this setting. " + | ||
| "Please set a different fee recipient.") |
There was a problem hiding this comment.
Let's avoid periods in our logs. Also, we should perhaps tell them to read our documentation regarding fee recipients?
prestonvanloon
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
related to #10292
What does this PR do? Why is it needed?
Error logs might be a little too scary for our end users ( especially developers) when not setting fee recipient, instead of using an error type we can use a warn type.