Properly Return Finalized Epoch in GetValidatorParticipation Archival Endpoint #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
0xKiwi,
nisdas,
prestonvanloon,
shayzluf and
terencechain
terencechain
previously approved these changes
Nov 22, 2019
prestonvanloon
previously approved these changes
Nov 23, 2019
| @@ -371,7 +371,7 @@ func (bs *Server) GetValidatorParticipation( | |||
| } | |||
| return ðpb.ValidatorParticipationResponse{ | |||
| Epoch: requestedEpoch, | |||
| Finalized: true, | |||
…o archive-finality
rauljordan
dismissed stale reviews from prestonvanloon and terencechain
via
068a2c1
Codecov Report
@@ Coverage Diff @@
## master #4091 +/- ##
=======================================
Coverage 10.74% 10.74%
=======================================
Files 165 165
Lines 10873 10873
=======================================
Hits 1168 1168
Misses 9557 9557
Partials 148 148 |
nisdas
approved these changes
Nov 25, 2019
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
… Endpoint (prysmaticlabs#4091) * properly handle retrieving archived finalized epochs * test passes for determining if epoch finalized * Merge branch 'master' into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge branch 'master' into archive-finality * prevent setup panic * Merge branch 'archive-finality' of github.com:prysmaticlabs/prysm into archive-finality * Merge refs/heads/master into archive-finality
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
… Endpoint (prysmaticlabs#4091) * properly handle retrieving archived finalized epochs * test passes for determining if epoch finalized * Merge branch 'master' into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge refs/heads/master into archive-finality * Merge branch 'master' into archive-finality * prevent setup panic * Merge branch 'archive-finality' of github.com:prysmaticlabs/prysm into archive-finality * Merge refs/heads/master into archive-finality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tracking issue
Description
Write why you are making the changes in this pull request
We currently face a problem that the
GetValidatorParticipationarchival endpoint always returns true for the value ofFinalized boolin the response. It turns out that was hardcoded.Write a summary of the changes you are making
Instead, we set the value of
finalizedin the response as:An invariant of finality is that any epoch <= a finalized epoch is also finalized by definition. Thanks @terencechain for the suggestion.