DB Improvements: Snappy compression, remove some unnecessary batch / goroutines #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
requested review from
rauljordan,
terencechain and
nisdas
and removed request for
rauljordan
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
=========================================
Coverage ? 22.15%
=========================================
Files ? 64
Lines ? 4446
Branches ? 0
=========================================
Hits ? 985
Misses ? 3352
Partials ? 109 |
terencechain
approved these changes
Nov 27, 2019
nisdas
approved these changes
Nov 27, 2019
|
Note that compression saves about 25% disk I/O and storage |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…goroutines (prysmaticlabs#4125) * do not use batch for SaveAttestations * use snappy compression * Encode / decode everything with snappy * Add snappy migration path * batch is probably fine... * fix test * gofmt * Merge branch 'master' of github.com:prysmaticlabs/prysm into remove-batch-attestations * add sanity check * remove that thing * gaz * Merge branch 'master' of github.com:prysmaticlabs/prysm into remove-batch-attestations
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…goroutines (prysmaticlabs#4125) * do not use batch for SaveAttestations * use snappy compression * Encode / decode everything with snappy * Add snappy migration path * batch is probably fine... * fix test * gofmt * Merge branch 'master' of github.com:prysmaticlabs/prysm into remove-batch-attestations * add sanity check * remove that thing * gaz * Merge branch 'master' of github.com:prysmaticlabs/prysm into remove-batch-attestations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title describes.
Seeing 50+blk/s on non archival nodes. 30+ blk/s on archival nodes.
Add
--snappyflag to migrate to snappy compressed database and faster sync times.Rollout schedule: