Account for Skipped Slots When Requesting for Blocks #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4130 +/- ##
======================================
Coverage 6.44% 6.44%
======================================
Files 171 171
Lines 11022 11022
======================================
Hits 710 710
Misses 10204 10204
Partials 108 108 |
prestonvanloon
previously approved these changes
Nov 27, 2019
rauljordan
previously approved these changes
Nov 27, 2019
rauljordan
dismissed stale reviews from prestonvanloon and themself
via
b549a34
rauljordan
approved these changes
Nov 27, 2019
| @@ -84,7 +84,7 @@ func (s *InitialSync) roundRobinSync(genesis time.Time) error { | |||
|
|
|||
| // Short circuit start far exceeding the highest finalized epoch in some infinite loop. | |||
| if start > helpers.StartSlot(highestFinalizedEpoch()+1) { | |||
| return nil, errors.New("attempted to ask for a start slot greater than the next highest epoch") | |||
| return nil, errors.Errorf("attempted to ask for a start slot of %d which is greater than the next highest epoch of %d", start, helpers.StartSlot(highestFinalizedEpoch()+1)) | |||
There was a problem hiding this comment.
Start slot is not correct here. This log doesn’t make sense as is
prestonvanloon
added a commit
that referenced
this pull request
Nov 27, 2019
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* fix log message from PR prysmaticlabs#4130 * Merge refs/heads/master into fix-log-2
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* fix log message from PR prysmaticlabs#4130 * Merge refs/heads/master into fix-log-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4041
Before sending out a new request, we check if the start slot of the request is higher than the finalized epoch. We also include potential skipped slots in our check.