Update cloudflare/roughtime dependency for ecosystem update #7224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks like this doesn't build. com_github_cloudflare_roughtime/mjd/mjd_linux.go:17:5: undefined: unix.TIME_OOP |
This reverts commit 1ace94a.
|
I originally thought it was an issue with CGO but it's not. The package now contains build constraints via I believe this is the same issue as bazel-contrib/rules_go#1215 but I do not know how to go about implementing the required changes. |
|
Hey @tannerryan thanks for opening this PR ! However as of #7299, we wont be using roughtime for the timebeing in Prysm, the reasons for discontinuing it are stated in the PR. It might be added back in the future once roughtime spec is standardized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Updates the cloudflare/roughtime dependency. The Roughtime server ecosystem list has been updated.
Which issues(s) does this PR fix?
#7223
Other notes for review
Not applicable.