Fix some static analysis problems related to initialization of fields.

przemek83 · Jan 13, 2025 · f2dd80d · f2dd80d
1 parent 54cf4b6
commit f2dd80d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/include/wble/FilterStrings.h b/include/wble/FilterStrings.h
@@ -58,7 +58,7 @@ class WBLE_EXPORT FilterStrings : public Filter
     static constexpr int maximumHeigh_{180};
 
     /// Flag indicating that additional place for scroll should be added.
-    bool addMarginForScrollBar_;
+    bool addMarginForScrollBar_{false};
 
     std::unique_ptr<DoubleClickEater> doubleClickEater_;
 

diff --git a/include/wble/ProgressBar.h b/include/wble/ProgressBar.h
@@ -65,9 +65,9 @@ class WBLE_EXPORT ProgressBar : public QWidget
 
     QPen pen_;
 
-    const QColor color_;
+    const QColor color_{Qt::blue};
 
-    const QBrush brush_;
+    const QBrush brush_{color_};
 
     static constexpr int LINE_WIDTH{10};
     static constexpr int TITLE_HEIGHT{LINE_WIDTH * 3};

diff --git a/src/FilterStrings.cpp b/src/FilterStrings.cpp
@@ -14,7 +14,6 @@ FilterStrings::FilterStrings(const QString& name, QStringList initialList,
     : Filter{name, parent},
       initialList_{std::move(initialList)},
       ui_{std::make_unique<Ui::FilterStrings>()},
-      addMarginForScrollBar_{false},
       doubleClickEater_{std::make_unique<DoubleClickEater>()}
 {
     ui_->setupUi(this);

diff --git a/src/ProgressBar.cpp b/src/ProgressBar.cpp
@@ -8,10 +8,7 @@
 #include <QTimer>
 
 ProgressBar::ProgressBar(QString title, QWidget* parent)
-    : QWidget{parent},
-      title_{std::move(title)},
-      color_{Qt::blue},
-      brush_{color_}
+    : QWidget{parent}, title_{std::move(title)}
 {
     setWindowTitle(title_);