Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mocking from tests #4287

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Remove mocking from tests #4287

merged 4 commits into from
Mar 21, 2024

Conversation

hauntsaninja
Copy link
Collaborator

Fixes #4275

@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Mar 20, 2024
@hauntsaninja hauntsaninja mentioned this pull request Mar 20, 2024
Closed
JelleZijlstra
JelleZijlstra approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always better to avoid mocking

@github-actions GitHub Actions
Copy link

diff-shades reports zero changes comparing this PR (bd6d608) to main (bf11956).

What is this? | Workflow run | diff-shades documentation

@hauntsaninja hauntsaninja merged commit c9d2635 into psf:main Mar 21, 2024
43 checks passed
@hauntsaninja hauntsaninja deleted the fix-test branch March 21, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unrelated testcases fail when total number of tests is increased beyond 367
2 participants
@hauntsaninja @JelleZijlstra