Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/checkout to v4 to stop node deprecation warnings #4379

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

SavageCore
Copy link
Contributor

Description

Update actions/checkout to v4 to stop node deprecation warnings
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Jun 11, 2024
@JelleZijlstra
Copy link
Collaborator

Thanks! Could you retarget this PR to the main branch instead of the stable branch?

@cooperlees
Copy link
Collaborator

Thanks, but I wonder if we should look into why Dependabot missed this? Or did the PR get closed?

@SavageCore SavageCore changed the base branch from stable to main June 11, 2024 14:23
@SavageCore
Copy link
Contributor Author

Thanks! Could you retarget this PR to the main branch instead of the stable branch?

Done, I just did it quickly from the edit button on the docs website, perhaps that target needs updating?

@cobaltt7
Copy link
Contributor

Thanks, but I wonder if we should look into why Dependabot missed this? Or did the PR get closed?

This doesn't update the repo CI, which already uses v4. This updates the docs for using Black in Actions.

@cooperlees
Copy link
Collaborator

Ahh, my bad, Didn't look close enough ...

@JelleZijlstra
Copy link
Collaborator

perhaps that target needs updating

Not sure what you mean there. The stable branch gets updated on releases.

@SavageCore
Copy link
Contributor Author

perhaps that target needs updating

Not sure what you mean there. The stable branch gets updated on releases.

I mean, if you want PRs coming in to target main then the edit link https://github.com/psf/black/edit/stable/docs/integrations/github_actions.md should change to https://github.com/psf/black/edit/main/docs/integrations/github_actions.md? Perhaps that isn't possible, I've not used Sphinx.

@JelleZijlstra
Copy link
Collaborator

I see, you mean the links on https://black.readthedocs.io/en/stable/ at the top. It wasn't clear from the previous messages in this PR that that's what you were doing. It would be good if we could edit that link to create PRs to the main branch instead, but I don't know how hard that is to do.

For this PR, you'll have to run prettier to reformat some of the markdown files you changed.

@SavageCore
Copy link
Contributor Author

For this PR, you'll have to run prettier to reformat some of the markdown files you changed.

Done. prettier seems happy now!

@hauntsaninja hauntsaninja merged commit 7e2afc9 into psf:main Jul 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants