Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document find_project_root ignoring pyproject.toml without [tool.black] #4425

Commits on Aug 2, 2024

  1. Document find_project_root ignoring pyproject.toml w/o tool.black

    Extend the docstring of black's `find_project_root` to mention that it ignores
    `pyproject.toml` files without a `[tool.black]` section.
    
    This is relevant because that function is also used by other python packages
    that use black. I found that e.g. datamodel-code-generator [1] uses that
    function and that there the ignoring of the pyproject.toml files lead to
    a degradation [2]. I think in that case it would be better to not use black's function
    for finding the pyproject.toml, but in any case this behavior should be documented.
    
    1: https://github.com/koxudaxi/datamodel-code-generator
    2: koxudaxi/datamodel-code-generator#2052
    Michael Eliachevitch authored and meliache committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c6b7a4c View commit details
    Browse the repository at this point in the history