Fix type error #4537
Merged
Fix type error #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cobalt <[email protected]>
Signed-off-by: cobalt <[email protected]>
|
Diff-shades will continue to fail until after this is merged, since it needs to build the main branch as well as the PR branch, and the main branch can't be built until after this is merged |
hauntsaninja
approved these changes
Dec 23, 2024
hauntsaninja
added
the
skip news
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a type error introduced in python/typeshed#13141
As mentioned in that PR, it is a legitimate bug, however
self.filenameis never not a string at runtimeRegardless, the type error is currently causing CI to fail and needs to be resolved
Checklist - did you ...
CHANGES.mdif necessary?